Skip to content
This repository was archived by the owner on Mar 13, 2018. It is now read-only.

Added iron-flext-layout-classes and included the iron-flext and iron-flex-alignment styles. - #260

Open
arielmagbanua wants to merge 2 commits into
googlearchive:masterfrom
arielmagbanua:master
Open

Added iron-flext-layout-classes and included the iron-flext and iron-flex-alignment styles.#260
arielmagbanua wants to merge 2 commits into
googlearchive:masterfrom
arielmagbanua:master

Conversation

@arielmagbanua

Copy link
Copy Markdown

Added paper-styles as import. Without it the paper-header-panel or the paper-drawer-panel won't render properly, both panel won't occupy the entire top part of browser window and the content won't show.

…e paper-drawer-panel won't render properly, both panel won't occupy the entire top part of browser window and the content won't show.
<link rel="import"
href="/bower_components/iron-flex-layout/iron-flex-layout.html">
<link rel="import"
href="/bower_components/paper-styles/paper-styles.html">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't import paper-styles.html like this. As mentioned in the docs (https://github.com/PolymerElements/paper-styles/blob/master/paper-styles.html#L33), we recommend importing the needed subfiles, not this generic one

@arielmagbanua

Copy link
Copy Markdown
Author

@notwaldorf yeah I see the real issue why header panel is not rendering properly in the responsive material design layouts guides. Thanks!

…flex-alignment it is needed by the header panels without it the header and content won't render properly and you can visibly see a gap space between the header and the top area of the browser window.
@arielmagbanua

Copy link
Copy Markdown
Author

@notwaldorf I pushed some new changes in this request. I Added iron-flext-layout-classes and included the iron-flext and iron-flex-alignment styles, it is needed by the header panels without it the header and content won't render properly and you can visibly see a gap space between the header and the top area of the browser window.

@arielmagbanua arielmagbanua changed the title Added paper-styles as import. Added iron-flext-layout-classes and included the iron-flext and iron-flex-alignment styles. Mar 26, 2016
@notwaldorf

Copy link
Copy Markdown
Contributor

/cc @arthurevans @blasten since this is docs and code i don't actually know about

@blasten

blasten commented Jun 22, 2016

Copy link
Copy Markdown
Contributor

I'd merge it if it looks good to @arthurevans

@arthurevans

Copy link
Copy Markdown
Contributor

LGTM, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants