Skip to content

feat: add a path option#74

Open
nikpivkin wants to merge 1 commit into
goph:masterfrom
nikpivkin:feat/path-option
Open

feat: add a path option#74
nikpivkin wants to merge 1 commit into
goph:masterfrom
nikpivkin:feat/path-option

Conversation

@nikpivkin
Copy link
Copy Markdown

Closes #73

@sagikazarmark
Copy link
Copy Markdown
Contributor

I wonder if it would make sense to make the path a positional argument instead for the relevant commands.

licensei check path/to/dir
licensei cache path/to/dir
licensei list path/to/dir

I could even imagine adding support for multiple paths in the future.

What do you think?

@jaxxstorm
Copy link
Copy Markdown

I think both are valid, positional argument probably has the best UX

@nikpivkin
Copy link
Copy Markdown
Author

@sagikazarmark Sounds reasonable, I'll fix it.

@skyzyx
Copy link
Copy Markdown

skyzyx commented Oct 31, 2023

I would love to not have to set a path at all. It would be simpler (for users) to be able to scan all child go.mod files automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a path flag

4 participants