Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f54c835169
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if dbName != "" && dbName == creds.originalName { | ||
| return s, func() tea.Msg { | ||
| return msgDBCheckResult{created: false, err: nil} | ||
| }, false |
There was a problem hiding this comment.
This early return skips checkDB whenever the entered DB name equals originalName. In a fresh setup, originalName is populated from the sample placeholder, so pressing Enter on the default value bypasses DB creation/emptiness validation entirely and the wizard reports success even if the target database does not exist yet.
Useful? React with 👍 / 👎.
| vals = append(vals, | ||
| yv("db", "name", testDBName), | ||
| yv("email", "driver", "test"), | ||
| yv("tracing", "enabled", "false"), // Обратите внимание: в вашем коде была строка "false" |
There was a problem hiding this comment.
This passes a string literal ("false") into the YAML patcher, which writes it as a string node, while ConfigT.Tracing.Enabled is a bool. Generated test config files can then fail to unmarshal (or carry the wrong scalar type) when loaded by code expecting a boolean.
Useful? React with 👍 / 👎.
1 participant
No description provided.