feat: use VarKind for variable semantics#290
Draft
aofei wants to merge 1 commit into
Draft
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This distinguishes receivers, parameters, named results, and local variables in semantic tokens and spx definitions while keeping field checks on `IsField()` where that API is clearer. Add regression tests for `TypeInfo`, semantic tokens, hover overviews, and spx definitions. Updates goplus/gogen#594 Updates goplus/xgo#2665 Signed-off-by: Aofei Sheng <aofei@aofeisheng.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #290 +/- ##
==========================================
+ Coverage 68.59% 68.78% +0.18%
==========================================
Files 55 56 +1
Lines 7041 7066 +25
==========================================
+ Hits 4830 4860 +30
+ Misses 1823 1817 -6
- Partials 388 389 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This distinguishes receivers, parameters, named results, and local variables in semantic tokens and spx definitions while keeping field checks on
IsField()where that API is clearer. Add regression tests forTypeInfo, semantic tokens, hover overviews, and spx definitions.Updates goplus/gogen#594
Updates goplus/xgo#2665