Skip to content

feat: use VarKind for variable semantics#290

Draft
aofei wants to merge 1 commit into
goplus:mainfrom
aofei:VarKind
Draft

feat: use VarKind for variable semantics#290
aofei wants to merge 1 commit into
goplus:mainfrom
aofei:VarKind

Conversation

@aofei
Copy link
Copy Markdown
Member

@aofei aofei commented Mar 26, 2026

This distinguishes receivers, parameters, named results, and local variables in semantic tokens and spx definitions while keeping field checks on IsField() where that API is clearer. Add regression tests for TypeInfo, semantic tokens, hover overviews, and spx definitions.

Updates goplus/gogen#594
Updates goplus/xgo#2665

@gemini-code-assist

This comment was marked as outdated.

This distinguishes receivers, parameters, named results, and local
variables in semantic tokens and spx definitions while keeping field
checks on `IsField()` where that API is clearer. Add regression tests
for `TypeInfo`, semantic tokens, hover overviews, and spx definitions.

Updates goplus/gogen#594
Updates goplus/xgo#2665

Signed-off-by: Aofei Sheng <aofei@aofeisheng.com>
gemini-code-assist[bot]

This comment was marked as outdated.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 26, 2026

Codecov Report

❌ Patch coverage is 86.66667% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.78%. Comparing base (064aca3) to head (89d67e5).

Files with missing lines Patch % Lines
internal/server/semantic_token.go 83.33% 2 Missing ⚠️
internal/server/var_kind.go 91.66% 1 Missing and 1 partial ⚠️
internal/server/spx_definition.go 87.50% 1 Missing ⚠️
internal/server/spx_util.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
+ Coverage   68.59%   68.78%   +0.18%     
==========================================
  Files          55       56       +1     
  Lines        7041     7066      +25     
==========================================
+ Hits         4830     4860      +30     
+ Misses       1823     1817       -6     
- Partials      388      389       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant