fix(ENGKNOW-2515): Write does NOT trigger rerun.#55
Merged
gmagnu merged 4 commits intoJun 20, 2025
Merged
Conversation
gmagnu
requested review from
andrimar1 and
david-chambliss-gdx
and removed request for
andrimar1
Junit Tests - Summary4 288 tests ±0 4 123 ✅ - 1 11m 43s ⏱️ + 1m 30s Results for commit 0eab1c5. ± Comparison against base commit a55fed1. This pull request skips 1 test.♻️ This comment has been updated with latest results. |
david-chambliss-gdx
approved these changes
Jun 20, 2025
Contributor
david-chambliss-gdx
left a comment
david-chambliss-gdx
left a comment
There was a problem hiding this comment.
While I would prefer the existing (new) safe behavior, given the decision to change it, this is done nicely.
It's nice that you keep the "safe" behavior available as a configurable option.
I did not know about that @Rule before. Nice to learn about it.
gmagnu
deleted the
ENGKNOW-2515-allow-create-with-explicit-write-to-use-cache-logic
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.