fix(ENGKNOW-2564): Fix dict cache error #59
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a dictionary cache error that was causing the -Y option (related to bucket access control) to sometimes not work correctly. The issue was that the cache key generation was inconsistent between different dictionary implementations, leading to cache misses or incorrect cache hits.
- Standardized cache key generation to include the
allowBucketAccessparameter consistently across dictionary implementations - Removed the unused
isSilentTagFilterparameter from cache key generation in DefaultTableAccessOptimizer - Added test coverage to verify dictionary bucket access functionality works correctly
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| DefaultTableAccessOptimizer.java | Updated cache key generation to remove unused isSilentTagFilter parameter and only include allowBucketAccess |
| Dictionary.java | Modified cache key to include allowBucketAccess parameter for consistent caching behavior |
| UTestDictionary.java | Added test case to verify dictionary bucket access functionality |
| BucketManager.java | Minor comment fix and made grace period configurable via system property |
Comments suppressed due to low confidence (1)
model/src/test/java/org/gorpipe/gor/Dictionary/UTestDictionary.java:421
- [nitpick] The filename 'testDictionaryWithNoBucketAccess.gord' doesn't match the test method name 'testDictionaryBucketAccess'. Consider renaming to 'testDictionaryBucketAccess.gord' for consistency.
File gordDict = workDir.newFile("testDictionaryWithNoBucketAccess.gord");
janeliutw
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix dict cache error causing -Y option sometimes not to work.