Skip to content

feat(ENGKNOW-2274): versioned link files phase 2#64

Merged
gmagnu merged 10 commits into
mainfrom
ENGKNOW-2274-versioned-link-files-phase-2
Aug 25, 2025
Merged

feat(ENGKNOW-2274): versioned link files phase 2#64
gmagnu merged 10 commits into
mainfrom
ENGKNOW-2274-versioned-link-files-phase-2

Conversation

@gmagnu
Copy link
Copy Markdown
Contributor

@gmagnu gmagnu commented Aug 20, 2025

This is a large PR with the following elements:

  • Adding -link and -vlink options to Write, ForkWrite and TvsAppend (which extends Write) to create links and versioned links while writing out files.
  • Added queryTime property to FileReader and SourceReference so we can track query time (start time) through out the query execution and pass it to the link file reader.
  • Adding -time options to gor (GorOptions) so we can set the query time (instead of using the current time).
  • Refactorings. Removing usued code, move code to more appropriate place. Use constans and util functions where appropriate.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 20, 2025

Junit Tests - Summary

4 311 tests  +19   4 147 ✅ +19   10m 34s ⏱️ -10s
  455 suites + 1     164 💤 ± 0 
  455 files   + 1       0 ❌ ± 0 

Results for commit 0d9f37a. ± Comparison against base commit c942a85.

♻️ This comment has been updated with latest results.

Comment thread documentation/src/commands.rst Outdated
Comment thread gortools/src/main/scala/gorsat/Commands/TsvAppend.scala Outdated
Comment thread gortools/src/main/scala/gorsat/Commands/TsvAppend.scala
Comment thread gortools/src/main/scala/gorsat/Commands/Write.scala
Copy link
Copy Markdown

@andrimar1 andrimar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @gmagnu also walked me through the changes

@gmagnu gmagnu merged commit 4b19fb1 into main Aug 25, 2025
11 checks passed
@gmagnu gmagnu deleted the ENGKNOW-2274-versioned-link-files-phase-2 branch August 25, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants