Skip to content

feat(ENGKNOW-2688): improve dangerous behaviour in calc#65

Merged
gmagnu merged 11 commits into
mainfrom
ENGKNOW-2688-improve-dangerous-behaviour-in-calc
Aug 28, 2025
Merged

feat(ENGKNOW-2688): improve dangerous behaviour in calc#65
gmagnu merged 11 commits into
mainfrom
ENGKNOW-2688-improve-dangerous-behaviour-in-calc

Conversation

@gmagnu
Copy link
Copy Markdown
Contributor

@gmagnu gmagnu commented Aug 25, 2025

  • Ban duplicate filenames after calc and rename.

gmagnu added 11 commits August 18, 2025 15:15
…ve-dangerous-behaviour-in-calc

# Conflicts:
#	documentation/src/commands.rst
#	gortools/src/main/scala/gorsat/Commands/TsvAppend.scala
#	gortools/src/main/scala/gorsat/Commands/Write.scala
#	gortools/src/main/scala/gorsat/InputSources/Nor.scala
#	gortools/src/test/java/gorsat/UTestGorWrite.java
#	gortools/src/test/java/gorsat/UTestGorWriteExplicit.java
#	model/src/main/java/org/gorpipe/gor/model/GorOptions.java
#	model/src/test/java/org/gorpipe/gor/driver/linkfile/UTestTimeTravel.java
@github-actions
Copy link
Copy Markdown

Junit Tests - Summary

4 314 tests  +3   4 150 ✅ +3   11m 2s ⏱️ -6s
  455 suites  - 1     164 💤 ±0 
  455 files    - 1       0 ❌ ±0 

Results for commit b8057e3. ± Comparison against base commit 4b19fb1.

This pull request removes 1 and adds 4 tests. Note that renamed tests count towards both.
gorsat.UTestHeaderFlags ‑ testValidHeaderUsedKeywords
gorsat.UTestHeaderFlags ‑ testValidHeaderUsedKeywordsWithDupAllowingDup
gorsat.UTestHeaderFlags ‑ testValidHeaderUsedKeywordsWithDupNotAllowingDup
gorsat.UTestRename ‑ renameToExisting
gorsat.parser.UTestCalc ‑ addsNewExistingColumn

Copy link
Copy Markdown

@rickbowman-dev63 rickbowman-dev63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall code LGTM

@gmagnu gmagnu merged commit 24e9375 into main Aug 28, 2025
11 checks passed
@gmagnu gmagnu deleted the ENGKNOW-2688-improve-dangerous-behaviour-in-calc branch August 28, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants