fix(ENGKNOW-2803): Fix case insensitivity in calcifmissing#70
Conversation
…ng if duplicate columns.
gmagnu
changed the title
Junit Tests - Summary4 316 tests +2 4 150 ✅ ±0 11m 26s ⏱️ + 1m 26s Results for commit e9c6bb1. ± Comparison against base commit 24e9375. This pull request skips 1 test.♻️ This comment has been updated with latest results. |
…ng if duplicate columns.
| if (ALLOW_DUPLICATE_COLUMNS || allowDuplicates) { | ||
| column = column + "x" | ||
| colToUp = column.toUpperCase | ||
| if (!allowDuplicates) { |
There was a problem hiding this comment.
if !allowDuplicates - just logs warning? Am I misinterpreting ?
There was a problem hiding this comment.
No, we allowDuplicates is false but we are overwriting at a global level with ALLOW_DUPLICATE_COLUMNS we print out a warning about the duplicate labels.
This is basically the case when we are switching over, we have many commands with allowDublicates = false but we overwrite for backward compatibiltity with ALLOW_DUPLICATE_COLUMNS=true, we print out the warning for those columns that have allowDublicates = false. When all the queries are fixed we will set ALLOW_DUPLICATE_COLUMNS=false.
There was a problem hiding this comment.
okay I see this is with the prior that ALLOW_DUPLICATE_COLUMNS is set to TRUE
2 participants
Uh oh!
There was an error while loading. Please reload this page.