feat(ENGKNOW-2903): gor services able to read production mdr from staging#77
Merged
gmagnu merged 7 commits intoNov 20, 2025
Conversation
Junit Tests - Summary4 333 tests +2 4 166 ✅ ±0 11m 13s ⏱️ -53s Results for commit b175970. ± Comparison against base commit 04e5c76. This pull request removes 2 and adds 4 tests. Note that renamed tests count towards both.This pull request removes 2 skipped tests and adds 4 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
…les. Update to use env query param.
gumson
reviewed
Nov 19, 2025
gumson
reviewed
Nov 19, 2025
| private static final Cache<MdrDocumentCacheKey, MdrUrlsResultItem> documentCache = | ||
| CacheBuilder.newBuilder().concurrencyLevel(4).expireAfterAccess(config.mdrCacheDuration(), TimeUnit.MINUTES).build(); | ||
|
|
||
| static { |
Contributor
There was a problem hiding this comment.
Not a big fan of this. Would rather explicitly load these resources.
Contributor
Author
There was a problem hiding this comment.
You mean the static loading of the config?
Contributor
Author
There was a problem hiding this comment.
It might be used by the static helper functions, so I would like to do the load in static initializer.
gumson
approved these changes
Nov 19, 2025
Contributor
gumson
left a comment
gumson
left a comment
There was a problem hiding this comment.
From a SOLID perspective this needs work, but other than that it looks good so I approve.
gmagnu
changed the title
gmagnu
deleted the
ENGKNOW-2903-gor-gor-services-able-to-read-production-mdr-from-staging
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.