ci: pin Go to 1.25.x across all workflows#739
Merged
Conversation
The golang group bump (#733) raised go.mod's directive to go 1.25.0, because golang.org/x/{sync,term,text,time} now require Go 1.25. The CI workflows still pinned 1.24.x (ci, coverage) and 1.21.x (lint, e2e) and only worked via setup-go's toolchain auto-download, which also breaks the coverage job ("go: no such tool covdata") and is incompatible with actions/setup-go v6 (GOTOOLCHAIN=local, #716). Pin every job to 1.25.x to match go.mod, fixing the coverage job and unblocking the setup-go v6 bump. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
ernado
force-pushed
the
fix/ci-go-version
branch
from
13ed2ee to
12da5d3
Compare
ernado
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The golang group bump (#733) raised
go.mod's directive togo 1.25.0, becausegolang.org/x/{sync,term,text,time}now require Go 1.25. However the CI workflows still pin older Go:ci.yml(test matrix) andcoverage.yml:1.24.xlint.yml(golangci-lint, check-mod, check-generate) ande2e.yml(vault, redis, s3, tg_io):1.21.xThese only build because
actions/setup-go@v5auto-downloads the 1.25 toolchain on demand. That has two problems:go: no such tool "covdata"because of the toolchain switch.actions/setup-go@v6(chore(deps): bump actions/setup-go from 5.5.0 to 6.4.0 #716) setsGOTOOLCHAIN=local, disabling the auto-download, so every job would fail withgo.mod requires go >= 1.25.0.This pins every job to
1.25.xto matchgo.mod, fixing the coverage job and unblocking the setup-go v6 bump.Test plan
🤖 Generated with Claude Code