Skip to content

hotfix: pagination key ... duplicate, change key#307

Merged
zaidaiman merged 1 commit into
mainfrom
hotfix/component-pagination-react-key-duplicate-error
Sep 17, 2025
Merged

hotfix: pagination key ... duplicate, change key#307
zaidaiman merged 1 commit into
mainfrom
hotfix/component-pagination-react-key-duplicate-error

Conversation

@harrisazmi
Copy link
Copy Markdown
Contributor

Main Description

hotfix : fix pagination key where pages is set to key and some design use initialPage ... middlePage ... endPage
where ... causes react to throw error due to ... duplication.

Type of change
[✅ ] fix feature
Affected endpoints
Backend
Checklist
[] My code follows the style guidelines of this project
[✅] I have performed a self-review of my code
[✅] I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
[✅] My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works

@harrisazmi harrisazmi self-assigned this Sep 13, 2025
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Sep 13, 2025

🦋 Changeset detected

Latest commit: 2673812

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@govtechmy/myds-react Patch
@govtechmy/myds-docs Patch
@govtechmy/kd-standard Patch
@govtechmy/myds-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 13, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
myds Ready Ready Preview Comment Sep 13, 2025 2:37am
myds-storybook Ready Ready Preview Comment Sep 13, 2025 2:37am

Copy link
Copy Markdown
Contributor

@zaidaiman zaidaiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@zaidaiman zaidaiman merged commit 0aa9b15 into main Sep 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants