Skip to content

Feature/SSD-809-ta-pagination#341

Open
adamhafidz19 wants to merge 1 commit into
mainfrom
feature/SSD-809-ta-pagination
Open

Feature/SSD-809-ta-pagination#341
adamhafidz19 wants to merge 1 commit into
mainfrom
feature/SSD-809-ta-pagination

Conversation

@adamhafidz19
Copy link
Copy Markdown
Contributor

Summarise the feature

Issue ticket: SSD-809

Description:

  • add ta-pagination component
  • done with the html, css and js files, along with the English documentation
  • only left for the Malay documentation (waiting for approval from Harris first)
Screenshot 2026-01-30 at 9 22 11 AM Screenshot 2026-01-30 at 9 21 56 AM

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@adamhafidz19 adamhafidz19 self-assigned this Jan 30, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 30, 2026

⚠️ No Changeset found

Latest commit: a79b715

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
myds Ready Ready Preview, Comment Jan 30, 2026 1:33am
myds-storybook Ready Ready Preview, Comment Jan 30, 2026 1:33am

Request Review

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new MYDS-compliant pagination component (TA-Pagination) for HTML/CSS/JavaScript projects, providing a transition path from vanilla implementations to React.

Changes:

  • Added ta-pagination component with three variants (Simple, Default, Full)
  • Implemented HTML preview, CSS styling with dark mode support, and JavaScript logic
  • Added comprehensive English documentation with usage examples and API guidance

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
ta-pagination-preview.html HTML preview file containing three pagination variant examples
pagination.js JavaScript logic for dynamic page rendering, ellipsis handling, and navigation
pagination.css Light mode styles for pagination component
pagination-dark.css Dark mode theme overrides for pagination component
ta-pagination.mdx Complete documentation including setup, usage, variants, and customization

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

transition: all 0.15s ease;
}

// ---------- Simple Type Pagination Styles ----------
Copy link

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSS comments should use /* ... */ syntax instead of // which is JavaScript comment syntax. This appears in documentation code examples that users may copy.

Suggested change
// ---------- Simple Type Pagination Styles ----------
/* ---------- Simple Type Pagination Styles ---------- */

Copilot uses AI. Check for mistakes.
box-shadow: none;
}

// ---------- Default Type Pagination Styles ----------
Copy link

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSS comments should use /* ... */ syntax instead of // which is JavaScript comment syntax. This appears in documentation code examples that users may copy.

Suggested change
// ---------- Default Type Pagination Styles ----------
/* ---------- Default Type Pagination Styles ---------- */

Copilot uses AI. Check for mistakes.
background-color: #f4f4f5;
}

// ---------- Full Type Pagination Styles ----------
Copy link

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSS comments should use /* ... */ syntax instead of // which is JavaScript comment syntax. This appears in documentation code examples that users may copy.

Copilot uses AI. Check for mistakes.
@adamhafidz19 adamhafidz19 changed the title feature/SSD-809-ta-pagination Feature/SSD-809-ta-pagination Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants