Feature/SSD-809-ta-pagination#341
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR introduces a new MYDS-compliant pagination component (TA-Pagination) for HTML/CSS/JavaScript projects, providing a transition path from vanilla implementations to React.
Changes:
- Added ta-pagination component with three variants (Simple, Default, Full)
- Implemented HTML preview, CSS styling with dark mode support, and JavaScript logic
- Added comprehensive English documentation with usage examples and API guidance
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| ta-pagination-preview.html | HTML preview file containing three pagination variant examples |
| pagination.js | JavaScript logic for dynamic page rendering, ellipsis handling, and navigation |
| pagination.css | Light mode styles for pagination component |
| pagination-dark.css | Dark mode theme overrides for pagination component |
| ta-pagination.mdx | Complete documentation including setup, usage, variants, and customization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| transition: all 0.15s ease; | ||
| } | ||
|
|
||
| // ---------- Simple Type Pagination Styles ---------- |
There was a problem hiding this comment.
CSS comments should use /* ... */ syntax instead of // which is JavaScript comment syntax. This appears in documentation code examples that users may copy.
| // ---------- Simple Type Pagination Styles ---------- | |
| /* ---------- Simple Type Pagination Styles ---------- */ |
| box-shadow: none; | ||
| } | ||
|
|
||
| // ---------- Default Type Pagination Styles ---------- |
There was a problem hiding this comment.
CSS comments should use /* ... */ syntax instead of // which is JavaScript comment syntax. This appears in documentation code examples that users may copy.
| // ---------- Default Type Pagination Styles ---------- | |
| /* ---------- Default Type Pagination Styles ---------- */ |
| background-color: #f4f4f5; | ||
| } | ||
|
|
||
| // ---------- Full Type Pagination Styles ---------- |
There was a problem hiding this comment.
CSS comments should use /* ... */ syntax instead of // which is JavaScript comment syntax. This appears in documentation code examples that users may copy.
Summarise the feature
Issue ticket: SSD-809
Description:
Type of change
Checklist