Skip to content

SSD-821: contact us template#346

Open
4fn4n wants to merge 8 commits into
developfrom
feat/SOF-103/template-section
Open

SSD-821: contact us template#346
4fn4n wants to merge 8 commits into
developfrom
feat/SOF-103/template-section

Conversation

@4fn4n
Copy link
Copy Markdown

@4fn4n 4fn4n commented Feb 13, 2026

Summarise the feature

Issue ticket # SSD-821

Description:

  • update contact us
  • update this old branch with develop latest
  • add with registration and login template

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@4fn4n 4fn4n self-assigned this Feb 13, 2026
@4fn4n 4fn4n added the enhancement New feature or request label Feb 13, 2026
@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
myds Ready Ready Preview, Comment Feb 13, 2026 4:34am
myds-storybook Ready Ready Preview, Comment Feb 13, 2026 4:34am

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 13, 2026

⚠️ No Changeset found

Latest commit: dae3bf7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new "Contact Us" template to the MYDS documentation, providing developers with a ready-to-use UI component for contact pages. The changes also include translation updates to the login and forgot password documentation files, and adds a pull request template to standardize PR submissions.

Changes:

  • Added a new ContactUsTemplate component with responsive layout, Google Maps integration, and social media links
  • Created comprehensive English and Malay documentation for the contact us template
  • Updated Malay translations in login and forgot password documentation for consistency
  • Added a standardized pull request template

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
apps/docs/templates/contact-us.tsx New React component providing a contact us page template with office information, map embed, and social links
apps/docs/content/docs/develop/(template)/contact-us.mdx English documentation for the contact us template with usage examples and customization guide
apps/docs/content/docs/develop/(template)/contact-us.ms.mdx Malay translation of contact us template documentation
apps/docs/content/docs/develop/(template)/login.ms.mdx Translation update: "Login" → "Log Masuk" for title consistency
apps/docs/content/docs/develop/(template)/forgot-password.ms.mdx Translation updates for consistency: "terlupa kata laluan" → "lupa kata laluan"
.github/pull_request_template.md Added standardized PR template with checklist for contributors

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

TiktokIcon,
} from "@govtechmy/myds-react/icon";

export default function ContactUsTemplate() {
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ContactUsTemplate component doesn't accept a className prop, but it's being used with className in the MDX documentation files (line 32 in both contact-us.mdx and contact-us.ms.mdx). Similar templates like LoginTemplate accept a className parameter for consistent styling flexibility. Add className as an optional prop parameter and apply it to the root element.

Copilot uses AI. Check for mistakes.

## Ringkasan Umum

Komponen `ContactUsTemplate` menyediakan contoh UI untuk skrin lupa kata laluan menggunakan komponen [MYDS](https://github.com/govtechmy/myds) Ia merangkumi:
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description incorrectly states this is for "skrin lupa kata laluan" (forgot password screen). This should be "skrin hubungi kami" (contact us screen) to match the actual purpose of the ContactUsTemplate component.

Suggested change
Komponen `ContactUsTemplate` menyediakan contoh UI untuk skrin lupa kata laluan menggunakan komponen [MYDS](https://github.com/govtechmy/myds) Ia merangkumi:
Komponen `ContactUsTemplate` menyediakan contoh UI untuk skrin hubungi kami menggunakan komponen [MYDS](https://github.com/govtechmy/myds) Ia merangkumi:

Copilot uses AI. Check for mistakes.
> - Butiran hubungan yang berfungsi untuk bingkai peta Google, nombor telefon dan e-mel
> - Pautan media sosial yang berfungsi
>
> You are expected to implement such logic based on your own system needs.
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This English text is mixed into a Malay documentation file. It should be translated to Malay for consistency. The expected translation would be: "Anda dijangka melaksanakan logik tersebut berdasarkan keperluan sistem anda sendiri."

Suggested change
> You are expected to implement such logic based on your own system needs.
> Anda dijangka melaksanakan logik tersebut berdasarkan keperluan sistem anda sendiri.

Copilot uses AI. Check for mistakes.
Comment on lines +205 to +212
- Responsive contact details section with google map frame, telephone and email.
- Social media links with icons styled according to the MYDS design guidelines.
- A mobile-friendly layout that adapts from stacked sections to a single row on large screens.

This contact us page template is built for **rapid development** and **easy integration**. It is designed to help teams get started faster by providing a layout that adheres to the **MYDS design system**, eliminating the need to piece together individual components manually.

> ⚠️ **Note**: This is a **design-only template**. It does **not** include any functional logic such as:
> - Working contact details for google map frame, telephone and email
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrase "google map" should be capitalized as "Google Map" to match proper noun capitalization standards, as it refers to the Google Maps product.

Suggested change
- Responsive contact details section with google map frame, telephone and email.
- Social media links with icons styled according to the MYDS design guidelines.
- A mobile-friendly layout that adapts from stacked sections to a single row on large screens.
This contact us page template is built for **rapid development** and **easy integration**. It is designed to help teams get started faster by providing a layout that adheres to the **MYDS design system**, eliminating the need to piece together individual components manually.
> ⚠️ **Note**: This is a **design-only template**. It does **not** include any functional logic such as:
> - Working contact details for google map frame, telephone and email
- Responsive contact details section with Google Map frame, telephone and email.
- Social media links with icons styled according to the MYDS design guidelines.
- A mobile-friendly layout that adapts from stacked sections to a single row on large screens.
This contact us page template is built for **rapid development** and **easy integration**. It is designed to help teams get started faster by providing a layout that adheres to the **MYDS design system**, eliminating the need to piece together individual components manually.
> ⚠️ **Note**: This is a **design-only template**. It does **not** include any functional logic such as:
> - Working contact details for Google Map frame, telephone and email

Copilot uses AI. Check for mistakes.

> ⚠️ **Note**: This is a **design-only template**. It does **not** include any functional logic such as:
> - Working contact details for google map frame, telephone and email
> - Working Social media links
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrase "Social media" should be lowercase "social media" to match standard English capitalization conventions where it's not at the beginning of a sentence or in a title.

Suggested change
> - Working Social media links
> - Working social media links

Copilot uses AI. Check for mistakes.
Comment on lines +417 to +418
## Customization

Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate "Customization" heading in English appears on line 417 immediately followed by "Penyesuaian" (the Malay translation of Customization) on line 419. Remove the duplicate English heading to maintain consistency in this Malay documentation file.

Suggested change
## Customization

Copilot uses AI. Check for mistakes.
Comment on lines +205 to +212
- Responsive contact details section with google map frame, telephone and email.
- Social media links with icons styled according to the MYDS design guidelines.
- A mobile-friendly layout that adapts from stacked sections to a single row on large screens.

This contact us page template is built for **rapid development** and **easy integration**. It is designed to help teams get started faster by providing a layout that adheres to the **MYDS design system**, eliminating the need to piece together individual components manually.

> ⚠️ **Note**: This is a **design-only template**. It does **not** include any functional logic such as:
> - Working contact details for google map frame, telephone and email
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrase "google map" should be capitalized as "Google Map" to match proper noun capitalization standards, as it refers to the Google Maps product. This same issue appears multiple times in the documentation.

Suggested change
- Responsive contact details section with google map frame, telephone and email.
- Social media links with icons styled according to the MYDS design guidelines.
- A mobile-friendly layout that adapts from stacked sections to a single row on large screens.
This contact us page template is built for **rapid development** and **easy integration**. It is designed to help teams get started faster by providing a layout that adheres to the **MYDS design system**, eliminating the need to piece together individual components manually.
> ⚠️ **Note**: This is a **design-only template**. It does **not** include any functional logic such as:
> - Working contact details for google map frame, telephone and email
- Responsive contact details section with Google Map frame, telephone and email.
- Social media links with icons styled according to the MYDS design guidelines.
- A mobile-friendly layout that adapts from stacked sections to a single row on large screens.
This contact us page template is built for **rapid development** and **easy integration**. It is designed to help teams get started faster by providing a layout that adheres to the **MYDS design system**, eliminating the need to piece together individual components manually.
> ⚠️ **Note**: This is a **design-only template**. It does **not** include any functional logic such as:
> - Working contact details for Google Map frame, telephone and email

Copilot uses AI. Check for mistakes.

## Customization

You can edit anything inside the code, its fully customizable!
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The possessive "its" should be the contraction "it's" (meaning "it is"). The sentence means "it is fully customizable", so the contraction with an apostrophe is correct here.

Suggested change
You can edit anything inside the code, its fully customizable!
You can edit anything inside the code, it's fully customizable!

Copilot uses AI. Check for mistakes.
## Ciri-ciri

- Susun atur responsif sepenuhnya dengan grid adaptif untuk skrin kecil hingga besar.

Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra blank list item (line 413) immediately after the first feature item and before the second feature item. This creates an empty bullet point in the rendered documentation. Remove this blank line to maintain proper list formatting.

Suggested change

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants