Add tasks for making individual languages live#2810
Open
DavidBiddle wants to merge 2 commits into
Open
Conversation
DavidBiddle
force-pushed
the
add-links-to-make-language-live-pages
branch
4 times, most recently
from
37f69d5 to
2b96e45
Compare
DavidBiddle
force-pushed
the
add-links-to-make-language-live-pages
branch
from
9a93465 to
16286e4
Compare
We need to prevent Welsh forms being made live if there are changes to the draft since the form was made live. If we don't, it's possible for a user to: - make an English version of the form live - make a change to that English version (e.g. adding or deleting a question) - complete the Welsh translations for the form - make the Welsh version live without making the English changes live In this case the different language versions would be out of sync, as the English and Welsh form documents would be from before and after the change respectively. This would lead to unexpected behaviour for form fillers when switching languages.
DavidBiddle
force-pushed
the
add-links-to-make-language-live-pages
branch
from
16286e4 to
b219ae9
Compare
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2810.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/nE8FUqW4/2892-separate-make-your-english-welsh-form-live-task-on-task-page
Adds new tasks to the task list, which will appear when the form:
These replace the existing make live task for Welsh forms.
Screenshots
A form with Welsh content and unpublished English changes:
A form with Welsh content and a live English version:
A draft form with no Welsh content:
A live form with a live Welsh version:
Things to consider when reviewing