Skip to content

Send bounce notifications to org admins if there are no group admins#2125

Draft
stephencdaly wants to merge 1 commit into
mainfrom
send-bounce-notificaiton-to-org-admins-if-there-are-no-group-admins
Draft

Send bounce notifications to org admins if there are no group admins#2125
stephencdaly wants to merge 1 commit into
mainfrom
send-bounce-notificaiton-to-org-admins-if-there-are-no-group-admins

Conversation

@stephencdaly
Copy link
Copy Markdown
Contributor

@stephencdaly stephencdaly commented May 27, 2026

What problem does this pull request solve?

Trello card: https://trello.com/c/8tbtHbMj

It is possible for a group to have no group admins. To ensure that we notify someone when submissions are bounced, send the email to org admins for the initial notification the day after the bounce if there are no group admins. In this email, include the content that refers to organisation admins, but not the content about having previously contacted them.

In this case, we will still send the follow-up notification 7 days later if the bounce hasn't been resolved.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

It is possible for a group to have no group admins. To ensure that we
notify someone when submissions are bounced, send the email to org
admins for the initial notification the day after the bounce if there
are no group admins. In this email, include the content that refers
to organisation admins, but not the content about having previously
contacted them.

In this case, we will still send the follow-up notification 7 days
later if the bounce hasn't been resolved.
@github-actions
Copy link
Copy Markdown
Contributor

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2125.submit.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant