Open
Conversation
Sidartha-CT
commented
Apr 20, 2026
| # Command Line Interface to run download scenario with tos : Voice and Video | ||
| ./lf_interop_qos.py --ap_name Cisco --mgr 192.168.209.223 --mgr_port 8080 --ssid Cisco | ||
| # Command Line Interface to run download scenario with tos for Real Devices: Voice and Video | ||
| python3 lf_interop_qos.py --ap_name Cisco --mgr 192.168.209.223 --mgr_port 8080 --ssid Cisco |
Collaborator
Author
There was a problem hiding this comment.
revert to old CLIs
| self.ssid = ssid | ||
| self.security = security | ||
| self.password = password | ||
| self.num_stations = num_stations | ||
|
|
||
| self._explicit_ssid = (ssid is not None) # to validate --real only scenario. |
Collaborator
Author
There was a problem hiding this comment.
remove redundant declaration
Comment on lines
1888
to
+1900
| def evaluate_qos(self, connections_download, connections_upload, drop_a_per, drop_b_per): | ||
| case_upload = "" | ||
| case_upload = "" | ||
| case_download = "" | ||
| tos_download = {'VI': [], 'VO': [], 'BK': [], 'BE': []} | ||
|
|
||
| tos_download = {'BK': [], 'BE': [], 'VI': [], 'VO': []} | ||
| tx_b_download = {'BK': [], 'BE': [], 'VI': [], 'VO': []} | ||
| rx_a_download = {'BK': [], 'BE': [], 'VI': [], 'VO': []} | ||
| tx_endps_download = {} | ||
| rx_endps_download = {} | ||
| tos_upload = {'VI': [], 'VO': [], 'BK': [], 'BE': []} | ||
| tx_b_upload = {'BK': [], 'BE': [], 'VI': [], 'VO': []} | ||
| rx_a_upload = {'BK': [], 'BE': [], 'VI': [], 'VO': []} | ||
|
|
||
| tos_upload = {'BK': [], 'BE': [], 'VI': [], 'VO': []} | ||
| tx_b_upload = {'BK': [], 'BE': [], 'VI': [], 'VO': []} | ||
| rx_a_upload = {'BK': [], 'BE': [], 'VI': [], 'VO': []} |
Collaborator
Author
There was a problem hiding this comment.
use the old ordering
| elif tb_str.endswith("h"): | ||
| return int(tb_str[:-1]) * 3600 | ||
| else: | ||
| raise ValueError("Invalid timebreak format. Use 5s, 5m or 1h") |
Collaborator
Author
There was a problem hiding this comment.
Please remove duration_to_seconds, replace with LFCliBase::parse_time
| self.station_profile.cleanup(self.station_list1, debug_=self.debug) | ||
| LFUtils.wait_until_ports_disappear(base_url=self.lfclient_url, | ||
| port_list=self.station_list, | ||
| port_list=self.station_list1, |
Collaborator
Author
There was a problem hiding this comment.
need justification here
Comment on lines
+1325
to
+1331
| for port in individual_device_data.keys(): | ||
| safe_port = port.replace('.', '-') | ||
| csv_name = f"ftp-{safe_port}" | ||
| individual_device_csv_names.append(csv_name) | ||
| indv_device_csv_list.extend(individual_device_csv_names) | ||
| self.individual_device_csv_list = indv_device_csv_list | ||
| # Final L4 dump |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.