Skip to content

Security fixes#5

Merged
gpappsoft merged 5 commits into
mainfrom
security
Apr 5, 2026
Merged

Security fixes#5
gpappsoft merged 5 commits into
mainfrom
security

Conversation

@gpappsoft

Copy link
Copy Markdown
Owner

security fixes:

  • Race condition Added sync.RWMutex to ChallengeStateStore — all Get/Set/Delete operations are now synchronized
  • Secret logging Removed RADIUS shared secrets, passwords, OTPs, client secrets, and response bodies from log output
  • OTP bypass Passwords <= 6 chars now get rejected instead of authenticating with an empty password
  • Auth on parse error AuthenticateUser now returns false + error when JSON unmarshal fails, instead of true
  • Predictable state GenerateRandomState returns an error instead of falling back to deterministic bytes
  • Ignored errors http.NewRequest errors are now checked and propagated

removed:

  • remove mschapv2 feature

additions:

Race condition		Added sync.RWMutex to ChallengeStateStore — all Get/Set/Delete operations are now synchronized
Secret logging		Removed RADIUS shared secrets, passwords, OTPs, client secrets, and response bodies from log output
OTP bypass	  	    Passwords <= 6 chars now get rejected instead of authenticating with an empty password
Auth on parse error	AuthenticateUser now returns false + error when JSON unmarshal fails, instead of true
Predictable state	GenerateRandomState returns an error instead of falling back to deterministic bytes
Ignored errors		http.NewRequest errors are now checked and propagated
@gpappsoft
gpappsoft merged commit e3dbaad into main Apr 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant