Modal tests#333
Merged
Merged
Conversation
ngc92
force-pushed
the
ngc92/modal-tests
branch
10 times, most recently
from
184b437 to
ffd5e05
Compare
ngc92
force-pushed
the
ngc92/modal-tests
branch
from
ffd5e05 to
c3e57bc
Compare
Member
Coverage report
This PR does not seem to contain any modification to coverable code. |
msaroufim
approved these changes
Aug 26, 2025
SinatrasC
pushed a commit
to SinatrasC/kernelbot
that referenced
this pull request
Jun 17, 2026
* utility fixture * pin torch version * added basic testing for modal launcher * modal token * use new function name * split into unit and integration tests * rename * lint * more interesting tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic, discord-free testing that modal submissions work.
We probably want to add some example scripts that use the additional libraries that we install (triton, tinygrad, cuda-python), to verify those work correctly, too, but that should be a pretty straightforward extension.