Temporary fix, send only split log#357
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements a temporary fix to prevent deployment issues by truncating leaderboard descriptions to 1500 characters when creating forum threads. The change addresses a length limit constraint in the Discord API.
- Truncates leaderboard descriptions to 1500 characters when they exceed this limit
- Maintains original description when under the limit
- Applied specifically to the forum thread creation functionality
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| definition.description[:1500] | ||
| if len(definition.description) > 1500 |
There was a problem hiding this comment.
The magic number 1500 is repeated and hardcoded. Consider defining it as a constant (e.g., MAX_DESCRIPTION_LENGTH = 1500) to improve maintainability and make the limit clear.
| definition.description[:1500] | |
| if len(definition.description) > 1500 | |
| definition.description[:MAX_DESCRIPTION_LENGTH] | |
| if len(definition.description) > MAX_DESCRIPTION_LENGTH |
| definition.description[:1500] | ||
| if len(definition.description) > 1500 | ||
| else definition.description, |
There was a problem hiding this comment.
The length check len(definition.description) > 1500 is performed after already slicing the string. Consider checking the length first to avoid unnecessary string slicing: definition.description[:1500] if len(definition.description) > 1500 else definition.description
| definition.description[:1500] | |
| if len(definition.description) > 1500 | |
| else definition.description, | |
| definition.description[:1500] if len(definition.description) > 1500 else definition.description, |
Coverage report
This PR does not seem to contain any modification to coverable code. |
This is a temporary fix jsut so I can deploy the problem, we should probably remove the functionality to create threads anyway as they aren't particularly used.