Skip to content

Allow zero submission rate limits#491

Merged
msaroufim merged 1 commit into
mainfrom
allow-zero-rate-limits
Jun 15, 2026
Merged

Allow zero submission rate limits#491
msaroufim merged 1 commit into
mainfrom
allow-zero-rate-limits

Conversation

@msaroufim

Copy link
Copy Markdown
Member

Summary

  • allow admin rate limits to use 0 submissions/hour
  • add a migration relaxing the DB constraint from > 0 to >= 0
  • cover zero-limit behavior in DB tests so a visible leaderboard can reject every new submission

Validation

  • uv run --extra dev pytest -q tests/test_admin_api.py::TestAdminRateLimits tests/test_leaderboard_db.py -k 'rate_limit'
  • python3 -m py_compile src/kernelbot/api/main.py src/libkernelbot/leaderboard_db.py src/migrations/20260319_01_allow-zero-rate-limits.py

Operational note

After this is deployed, set qr to 0 submissions/hour for both test and leaderboard categories to keep it visible while blocking new submissions.

@github-actions

Copy link
Copy Markdown

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/libkernelbot
  utils.py
Project Total  

This report was generated by python-coverage-comment-action

@msaroufim msaroufim merged commit ac6a635 into main Jun 15, 2026
4 checks passed
msaroufim added a commit that referenced this pull request Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant