Hide submissions with any failed secret run#492
Merged
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
leaderboardpasses, secretbenchmarkfailsWhy
PR #490 only filtered failed secret runs with the same mode as the public scored run. QR submissions can fail secret
benchmarkbefore producing a secretleaderboardrun, while still having a passing publicleaderboardscore. Those should not appear on rankings.Validation
uv run --extra dev pytest -q tests/test_leaderboard_db.py -k 'failed_secret or leaderboard_submission_ranked or leaderboard_submission_count'uv run --extra dev python -m py_compile src/libkernelbot/leaderboard_db.pygit diff --check800895,800582, and800601