Validation: Add immediate data pipeline validation tests #4547

shaoboyan091 · 2025-12-31T06:50:02Z

Adds pipeline_immediate.spec.ts to validate immediate data usage in RenderPassEncoder, ComputePassEncoder, and RenderBundleEncoder.

Tests cover:

Required immediate data slots are set.
Unused variables do not require slots.
Pipeline creation fails if shader immediate size exceeds layout limit.
RenderBundle execution invalidates pipeline and immediate data state.

Issue: #

Requirements for PR author:

All missing test coverage is tracked with "TODO" or .unimplemented().
New helpers are /** documented */ and new helper files are found in helper_index.txt.
Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

Tests are properly located in the test tree.
Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

src/webgpu/api/validation/createPipelineLayout.spec.ts

src/webgpu/api/validation/encoding/programmable/pipeline_immediate.spec.ts

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/webgpu/api/validation/encoding/programmable/pipeline_immediate.spec.ts

src/webgpu/api/validation/createPipelineLayout.spec.ts

src/webgpu/api/validation/encoding/programmable/pipeline_immediate.spec.ts

github-actions · 2026-01-07T07:45:04Z

Results for build job (at bdeb595):

+webgpu:api,validation,encoding,programmable,pipeline_immediate:required_slots_set:* - 161 cases, 161 subcases (~1/case)
+webgpu:api,validation,encoding,programmable,pipeline_immediate:unused_variable:* - 12 cases, 12 subcases (~1/case)
+webgpu:api,validation,encoding,programmable,pipeline_immediate:overprovisioned_immediate_data:* - 6 cases, 6 subcases (~1/case)
+webgpu:api,validation,encoding,programmable,pipeline_immediate:render_bundle_execution_state_invalidation:* - 1 cases, 2 subcases (~2/case)
-TOTAL: 285744 cases, 2344468 subcases
+TOTAL: 285924 cases, 2344649 subcases

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/webgpu/api/validation/createPipelineLayout.spec.ts

src/webgpu/api/validation/encoding/programmable/pipeline_immediate.spec.ts

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/webgpu/api/validation/encoding/programmable/pipeline_immediate.spec.ts

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/webgpu/api/validation/encoding/programmable/pipeline_immediate.spec.ts

kainino0x · 2026-01-09T06:23:04Z

Sorry, bit swamped. Should be able to review tomorrow.

src/webgpu/api/validation/encoding/programmable/pipeline_immediate.spec.ts

src/webgpu/api/validation/createPipelineLayout.spec.ts

src/webgpu/api/validation/encoding/programmable/pipeline_immediate.spec.ts

Kangz · 2026-01-12T10:11:35Z

src/webgpu/api/validation/encoding/programmable/pipeline_immediate.spec.ts

+        `;
+        break;
+      case 'struct_padding':
+        kRequiredSize = 64;


Suggested change

kRequiredSize = 64;

kRequiredSize = 40;

Done. And it indeed caught a bug in implementation! Tint calculated whole immediate block struct size as the immediate block size. And it doesn't get rid of tail padding bytes so it triggers validation report wrong fail due to it. (report used more bytes than layout required)

src/webgpu/api/validation/encoding/programmable/pipeline_immediate.spec.ts

src/webgpu/api/validation/createPipelineLayout.spec.ts

Adds `pipeline_immediate.spec.ts` to validate immediate data usage in RenderPassEncoder, ComputePassEncoder, and RenderBundleEncoder. Tests cover: - Required immediate data slots are set. - Unused variables do not require slots. - Pipeline creation fails if shader immediate size exceeds layout limit. - RenderBundle execution invalidates pipeline and immediate data state.

kainino0x · 2026-01-21T04:42:21Z

src/webgpu/api/validation/encoding/programmable/pipeline_immediate.spec.ts

        setImmediates(16, 16);
+      } else if (scenario === 'multiple_variables') {
+        // v1: struct S {u32} (size 4, align 4) -> offset 0
+        // v2: vec2<u32> (size 8, align 8) -> offset 8


I thought the two immediate blocks were treated totally independently and so v2 would be at offset 0, and whatever data is in the immediates would get aliased by the two stages with different types.

I was thinking it would work like:

struct S1 { a: u32, x: u32 }; // slots used: 1100 0000 struct S2 { a: f32, y: vec4<f32> }; // slots used: 1000 1111 // so the slots required to be set are: 1100 1111

If this is wrong then I'll need to understand a bit better.

First, I think the code comment here is incorrect. You understand is correct. They should be treated independently.
And I think the proposed case is better than what I want to do(padding bytes in fragment overlap with required bytes in vertex). Thanks!

shaoboyan091 requested a review from Copilot December 31, 2025 06:50

Copilot started reviewing on behalf of shaoboyan091 December 31, 2025 06:50 View session

Copilot AI reviewed Dec 31, 2025

View reviewed changes

shaoboyan091 force-pushed the immediate-state branch 2 times, most recently from a15fb20 to 90010d1 Compare January 7, 2026 07:40

shaoboyan091 requested a review from Copilot January 7, 2026 07:40

Copilot started reviewing on behalf of shaoboyan091 January 7, 2026 07:41 View session

Copilot AI reviewed Jan 7, 2026

View reviewed changes

shaoboyan091 force-pushed the immediate-state branch from 90010d1 to adcf898 Compare January 7, 2026 08:35

shaoboyan091 requested a review from Copilot January 7, 2026 08:37

Copilot started reviewing on behalf of shaoboyan091 January 7, 2026 08:37 View session

Copilot AI reviewed Jan 7, 2026

View reviewed changes

shaoboyan091 force-pushed the immediate-state branch 2 times, most recently from 080f99a to b4c612d Compare January 7, 2026 10:10

shaoboyan091 requested a review from Copilot January 7, 2026 10:11

Copilot started reviewing on behalf of shaoboyan091 January 7, 2026 10:12 View session

Copilot AI reviewed Jan 7, 2026

View reviewed changes

src/webgpu/api/validation/encoding/programmable/pipeline_immediate.spec.ts Outdated Show resolved Hide resolved

src/webgpu/api/validation/encoding/programmable/pipeline_immediate.spec.ts Outdated Show resolved Hide resolved

shaoboyan091 force-pushed the immediate-state branch from b4c612d to bed2542 Compare January 8, 2026 08:22

shaoboyan091 requested a review from Copilot January 8, 2026 08:22

Copilot started reviewing on behalf of shaoboyan091 January 8, 2026 08:23 View session

Copilot AI reviewed Jan 8, 2026

View reviewed changes

src/webgpu/api/validation/encoding/programmable/pipeline_immediate.spec.ts Outdated Show resolved Hide resolved

src/webgpu/api/validation/encoding/programmable/pipeline_immediate.spec.ts Outdated Show resolved Hide resolved

shaoboyan091 requested review from Kangz and kainino0x January 8, 2026 08:41

Kangz reviewed Jan 12, 2026

View reviewed changes

src/webgpu/api/validation/encoding/programmable/pipeline_immediate.spec.ts Outdated Show resolved Hide resolved

Kangz reviewed Jan 12, 2026

View reviewed changes

kainino0x reviewed Jan 14, 2026

View reviewed changes

shaoboyan091 requested review from Kangz and kainino0x January 16, 2026 07:06

shaoboyan091 added 3 commits January 20, 2026 09:53

Address comments

b1fc122

Fix type check issues

ae2cc60

shaoboyan091 force-pushed the immediate-state branch from b6116d0 to ae2cc60 Compare January 20, 2026 02:49

shaoboyan091 added 2 commits January 20, 2026 14:28

Add multiple immediate variables test case

bab7ae0

Regenerate Cache

17e7666

kainino0x reviewed Jan 21, 2026

View reviewed changes

shaoboyan091 marked this pull request as draft January 21, 2026 05:19

Clean comments and update multiple_variable cases

bdeb595

Validation: Add immediate data pipeline validation tests #4547

Are you sure you want to change the base?

Validation: Add immediate data pipeline validation tests #4547

Uh oh!

Conversation

shaoboyan091 commented Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

kainino0x commented Jan 9, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kangz Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

shaoboyan091 Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kainino0x Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

shaoboyan091 commented Dec 31, 2025 •

edited

Loading

github-actions bot commented Jan 7, 2026 •

edited

Loading

shaoboyan091 Jan 16, 2026 •

edited

Loading