Skip to content

Improve the sensitivity of the array_zero_value tests #4550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andyleiserson wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve the sensitivity of the array_zero_value tests #4550

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f892cb
Improve the sensitivity of the value_constructor tests
andyleiserson Jan 6, 2026
8b7a140
Run all the array/struct tests on each of const/let/var
andyleiserson Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 33 additions & 8 deletions src/webgpu/shader/validation/expression/call/builtin/value_constructor.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import { ShaderValidationTest } from '../../../shader_validation_test.js';

export const g = makeTestGroup(ShaderValidationTest);

const kDeclTypes = ['const', 'let', 'var'];
const kScalarTypes = ['bool', 'i32', 'u32', 'f32', 'f16'];

g.test('scalar_zero_value')
Expand Down Expand Up @@ -479,7 +480,11 @@ const kArrayCases: Record<string, ArrayCase> = {

g.test('array_zero_value')
.desc('Tests zero value array constructors')
.params(u => u.combine('case', keysOf(kArrayCases)))
.params(u =>
u
.combine('case', keysOf(kArrayCases)) //
.combine('decltype', kDeclTypes)
)
.fn(t => {
const testcase = kArrayCases[t.params.case];
const decl = `array<${testcase.element}, ${testcase.size}>`;
Expand All @@ -490,13 +495,19 @@ g.test('array_zero_value')
struct invalid_S {
x : array<u32>
}
const x : ${decl} = ${decl}();`;
fn main() {
${t.params.decltype} x : ${decl} = ${decl}();
}`;
t.expectCompileResult(testcase.valid, code);
});

g.test('array_value')
.desc('Tests array value constructor')
.params(u => u.combine('case', keysOf(kArrayCases)))
.params(u =>
u
.combine('case', keysOf(kArrayCases)) //
.combine('decltype', kDeclTypes)
)
.fn(t => {
const testcase = kArrayCases[t.params.case];
const decl = `array<${testcase.element}, ${testcase.size}>`;
Expand All @@ -507,7 +518,9 @@ g.test('array_value')
struct invalid_S {
x : array<u32>
}
const x : ${decl} = ${decl}(${testcase.values});`;
fn main() {
${t.params.decltype} x : ${decl} = ${decl}(${testcase.values});
}`;
t.expectCompileResult(testcase.valid, code);
});

Expand Down Expand Up @@ -574,23 +587,35 @@ const kStructCases = {

g.test('struct_zero_value')
.desc('Tests zero value struct constructors')
.params(u => u.combine('case', keysOf(kStructCases)))
.params(u =>
u
.combine('case', keysOf(kStructCases)) //
.combine('decltype', kDeclTypes)
)
.fn(t => {
const testcase = kStructCases[t.params.case];
const code = `
${testcase.decls}
const x : ${testcase.name} = ${testcase.name}();`;
fn main() {
${t.params.decltype} x : ${testcase.name} = ${testcase.name}();
}`;
t.expectCompileResult(testcase.valid, code);
});

g.test('struct_value')
.desc('Tests struct value constructors')
.params(u => u.combine('case', keysOf(kStructCases)))
.params(u =>
u
.combine('case', keysOf(kStructCases)) //
.combine('decltype', kDeclTypes)
)
.fn(t => {
const testcase = kStructCases[t.params.case];
const code = `
${testcase.decls}
const x : ${testcase.name} = ${testcase.name}(${testcase.values});`;
fn main() {
${t.params.decltype} x : ${testcase.name} = ${testcase.name}(${testcase.values});
}`;
t.expectCompileResult(testcase.valid, code);
});

Expand Down