-
Notifications
You must be signed in to change notification settings - Fork 101
Skip unsupported texture formats #4567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
||
| const requiredFeature = getRequiredFeatureForTextureFormat(format); | ||
| if (requiredFeature) { | ||
| t.skipIfDeviceDoesNotHaveFeature(requiredFeature); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm........ in theory, the correct thing to do here would be to check wgslLanguageFeatures and not the device features. Because:
- It's not just the new formats that should be skipped when the browser doesn't have support, it's also the existing formats that were newly-added to WGSL.
- We should be running this test if the browser (compiler) supports the format, even if the device doesn't.
But we didn't add a wgsl language feature! Filed gpuweb/gpuweb#5524
|
|
||
| g.test('var_decl') | ||
| .desc( | ||
| `Checks that the read and read_write access modes are only allowed with the language feature present` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| `Checks that the read and read_write access modes are only allowed with the language feature present | |
| TODO(https://github.com/gpuweb/gpuweb/issues/5524): Fix this to check wgslLanguageFeatures | |
| of the device features. | |
| ` |
Changes the
readonly_and_readwrite_storage_texturestest to check for feature support.Issue: none
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.