Skip to content

ObserveWithExemplar support other spancontext types#662

Draft
mdisibio wants to merge 1 commit into
mainfrom
exemplar-otel
Draft

ObserveWithExemplar support other spancontext types#662
mdisibio wants to merge 1 commit into
mainfrom
exemplar-otel

Conversation

@mdisibio

@mdisibio mdisibio commented Mar 6, 2025

Copy link
Copy Markdown
Contributor

What this PR does:
Was researching that Tempo no longer exported exemplars and identified the root cause: The dskit server instrumentation to export request_duration_seconds histogram and exemplars no longer works for apps using the Otel or other (non-jaeger) SDK, because we are only checking for jaeger.SpanContext. This updates it to also support other, including Otel SpanContext and bridgeSpanContext

Because this repo doesn't have a dependency on otel, some work is needed to get the data without access to the underlying types, and a simple interface conversion doesn't seem to be possible.

Therefore this is Draft so we can decide on the approach. It's possible that were is a better method that doesn't use reflection.

Which issue(s) this PR fixes:

Fixes #

Checklist

  • Tests updated
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@mdisibio mdisibio added the bug Something isn't working label Mar 6, 2025
@colega

colega commented Apr 16, 2025

Copy link
Copy Markdown
Contributor

I'm working on something that should solve this in a different way, please hold on here ⌛

@colega colega mentioned this pull request Apr 17, 2025
2 tasks
@colega

colega commented Apr 17, 2025

Copy link
Copy Markdown
Contributor

@mdisibio here's what I'm doing: #681

@pracucci

pracucci commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

Hi! 👋 We recently merged #947 which changed the CI configuration for unit tests. To get CI passing on this PR, please rebase on the latest main branch:

git fetch origin main
git rebase origin/main
git push --force-with-lease

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants