feat: Add the option of a lower read consistency level#11345
Conversation
This can be set globally and overridden per tenant, and allows trading availability for consistency.
pracucci
left a comment
There was a problem hiding this comment.
A quick comment about the correctness (I left the rest of the team comment whether it's something desired for Mimir or not). If we want to allow partial query results, then it's not just about how we build the replication set but also we have to change the quorum logic, implemented in ring.DoBatchWithOptions() (quorum is implemented here).
@pracucci could you point out the logic that needs to be updated? I'm asking because I already looked at that code and I thought it did not need to be changed... |
|
Thank you for your contribution. This pull request has been marked as stale because it has had no activity in the last 150 days. It will be closed in 30 days if there is no further activity. If you need more time, you can add a comment to the PR. |
|
This pull request has been closed because it has been stale for 30 days with no activity. Feel free to reopen if you want to continue working on this. |
[Note that this MR contains a large amount of changes to vendor/ as it depends on this dskit PR]
Using a lower read consistency level allows trading lower consistency for higher availability.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.