fix(ui): do not parse label selector - send as is to server.#5274
Open
korniltsev-grafanista wants to merge 1 commit into
Open
fix(ui): do not parse label selector - send as is to server.#5274korniltsev-grafanista wants to merge 1 commit into
korniltsev-grafanista wants to merge 1 commit into
Conversation
marcsanmi
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change the UI does not allow to send arbitrary labels - the app parsed
service_nameandprofile_typelabel from the query and only sent them.In this change, I remove the
profile_typefrom the label selector - it is stored separately and we do not append and parse back the query.Furthermore we do not parse labelSelector at all - we send it as is to the server, letting the server validate the query. We still parse the label selector for service name detection, but it is no longer required and that means we can query even without
service_name.As a result we don't need the callbacks from the
userPyroscopeQueryanymore and they are removed too.