Skip to content

fix(helm): respect metastore raft extraArgs overrides#5275

Open
immanuwell wants to merge 1 commit into
grafana:mainfrom
immanuwell:fix-helm-metastore-raft-overrides
Open

fix(helm): respect metastore raft extraArgs overrides#5275
immanuwell wants to merge 1 commit into
grafana:mainfrom
immanuwell:fix-helm-metastore-raft-overrides

Conversation

@immanuwell

Copy link
Copy Markdown
Contributor

Helm checks metastore.raft.server-id before adding defaults for metastore.raft.bind-address and metastore.raft.bootstrap-peers.

So if a user sets either override in pyroscope.extraArgs, the chart still renders the default too. The later default wins, pretty sneaky, so the override gets clobbered.

This patch checks the matching keys instead.

Repro:

tmp=$(mktemp)
printf 'architecture:\n  storage:\n    v1: false\n    v2: true\npyroscope:\n  extraArgs:\n    metastore.raft.bind-address: ":1234"\n' > "$tmp"
helm template -n default --kube-version 1.23.0 pyroscope-dev ./operations/pyroscope/helm/pyroscope -f "$tmp" | rg 'metastore\.raft\.bind-address='
rm -f "$tmp"

Before:

-metastore.raft.bind-address=:1234
-metastore.raft.bind-address=:9099

After:

-metastore.raft.bind-address=:1234

Same thing happens for metastore.raft.bootstrap-peers.

@immanuwell immanuwell requested a review from a team as a code owner June 19, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant