feat: allow additional jpaths#1491
Draft
zerok wants to merge 5 commits into
Draft
Conversation
This will allow injecting additional jpath elements into the Resolve function. Sorting happens now every time that function is called which is not really ideal but also - given the size of the list - shouldn't matter all that much.
This adds zero value to the end-user and also breaks various tests.
Contributor
Author
|
I don't think it will be possible to integrate this into the |
This is especially intended for `show`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EXPERIMENTAL
In a few scenarios it would be extremely helpful to extend the JPATH defined by Tanka. Let's say we want to override certain dependencies for certain environments in order to test them there. Using
<base>/vendoris an option but it would require those dependencies to be copied to every environment we want to test it it.With this, we could use the
tkrc.yamlfile and define something like this:The configuration above would add the
shared-vendors/test/vendorfolder to the search path if the environments are targetting the clusterstest-cluster-0ortest-cluster-1. Anything in that folder would be considered before the content of the<root>/vendorfolder.TODOs