Skip to content

fix(helm): skip OCI repos in RepoUpdate#2055

Open
immanuwell wants to merge 1 commit into
grafana:mainfrom
immanuwell:fix/helm-oci-repo-update
Open

fix(helm): skip OCI repos in RepoUpdate#2055
immanuwell wants to merge 1 commit into
grafana:mainfrom
immanuwell:fix/helm-oci-repo-update

Conversation

@immanuwell

Copy link
Copy Markdown

RepoUpdate passes all repos to helm repo update including OCI ones - that straight up fails since OCI registries dont use the index-based update flow. Pull already handles this correctly by special-casing oci:// URLs, RepoUpdate was just missing the same treatment. Filter them out, return early if nothing's left.

Also TestAddOCI was panicking (index out of range [0] with length 0) because assert is non-fatal and continued into listResult[0] after a failed check. Switched to require to fail fast.

Reproduce (panics before this fix):

go test ./pkg/helm/... -run TestAddOCI

@immanuwell immanuwell requested a review from a team as a code owner May 29, 2026 15:32
@cla-assistant

cla-assistant Bot commented May 29, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@cla-assistant

cla-assistant Bot commented May 29, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant