feat: Patch zutil for macos clang 17#1
Merged
ospencer merged 1 commit intograin-lang:masterfrom Sep 5, 2025
spotandjake:spotandjake-clang-17
Merged
feat: Patch zutil for macos clang 17#1ospencer merged 1 commit intograin-lang:masterfrom spotandjake:spotandjake-clang-17
zutil for macos clang 17#1ospencer merged 1 commit intograin-lang:masterfrom
spotandjake:spotandjake-clang-17
Conversation
marcusroberts
approved these changes
Aug 23, 2025
Member
marcusroberts
left a comment
marcusroberts
left a comment
There was a problem hiding this comment.
Building for me too now!
Member
Author
|
After this is merged I'll open a pr to libbinaryen with the updated commit and a pr to grain with an esy override until we can binaryen.ml is updated. Here is a working version of downstream libbinaryen with this version of I also have a working version of the grain compiler here https://github.com/spotandjake/grain/tree/spotandjake-clang-17 its based off my ocaml 5 work though as a few opam packages seem to have been removed which were causing a ton of conflicts trying to get it to work off main. |
ospencer
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Macos sequoia updated to clang 17 in xcodes command line tools which broke cmake builds this is a small patch to
zutilfixing it.I also added some additional macos tests for different versions to ensure this isn't breaking anything in older versions.