feat(compiler): Arbitrary-position spreads#1665
feat(compiler): Arbitrary-position spreads#1665alex-snezhko wants to merge 3 commits intograin-lang:mainfrom
Conversation
alex-snezhko
requested review from
jozanza,
marcusroberts,
ospencer,
peblair and
phated
as code owners
ospencer
left a comment
ospencer
left a comment
There was a problem hiding this comment.
Overall, the approach looks good here. Just a few things to clean up :)
| // We have to compose this list by hand because of the complexity of if a list item | ||
| // is followed by a comment, the comma must come before the comment. | ||
| // It also impacts how we force a new line for a line ending comment at the end of a list | ||
| // without introducing an extra blank line when bringing the indentation back in again |
There was a problem hiding this comment.
On my list of things to do is create a new parsetree node for lists, now that it's a part of the compiler. Seems like I should hurry up and do that so we can rebase this on top to prevent this from getting even more complex?
There was a problem hiding this comment.
Sure, if you'd like; I don't think it should be too much work to rebase this off of such a feature
|
I addressed the majority of the feedback, will wait until list ADT nodes gets merged to un-bork the formatter :P |
|
What should the fate of this PR be? Should it be tabled until further notice or is it still planned for 0.6? There was some discussion in a community meeting a little while ago to completely change list syntax (using arrows to connect elements or something of the sort), but that would cause the current syntax to be breaking regardless |
alex-snezhko
force-pushed
the
arbitrary-pos-spread
branch
from
8af0f18 to
732027f
Compare
2 participants
Support for putting the spread syntax at any position in a list (also spread support for arrays).
Example:
Closes #288