Conversation
hangleang
force-pushed
the
feature/payload-envelope
branch
3 times, most recently
from
4fb8c1f to
c948fd5
Compare
hangleang
force-pushed
the
feature/payload-envelope
branch
from
c948fd5 to
17eb854
Compare
|
@hangleang please rebase this on develop |
hangleang
force-pushed
the
feature/payload-envelope
branch
from
17eb854 to
b0cf339
Compare
done! |
hangleang
force-pushed
the
feature/payload-envelope
branch
2 times, most recently
from
28a1746 to
f80a754
Compare
|
Could you open a PR to |
created a PR grandinetech/eth2_libp2p#23, also include 2 Povilas commits which didn't merge on |
That's for payload attestations — we'll need those too, but they're out of scope for this PR. What we need here is a PR to eth2_libp2p that adds support for payload envelopes specifically. |
here it is: grandinetech/eth2_libp2p#24 |
| // unless they choose to self-build, as favor or no active builders | ||
| let mut payload_with_data = None; | ||
| if self.beacon_state.post_gloas().is_none_or(|state| { | ||
| self.options.enable_local_payload_building |
There was a problem hiding this comment.
Note: It looks like that using --enable-local-payload-building flag not only enables but forces self-build. If this is the feature that we want, it should probably named --force-local-payload-building or --force-self-build
There was a problem hiding this comment.
We can figure out the naming later
hangleang
force-pushed
the
feature/payload-envelope
branch
2 times, most recently
from
b195693 to
332014f
Compare
| // Note: Unlike blobs/columns which use serve_range checks, envelopes are needed | ||
| // for all Gloas slots (similar to blocks) for state transition | ||
| //TODO: confirm this from hangleang | ||
| if sync_mode.is_default() && config.phase_at_slot::<P>(start_slot) >= Phase::Gloas { |
There was a problem hiding this comment.
It should adjust start_slot based on Gloas start slot and not skip the whole batch. Example: if start_slot is gloas_start_slot - 1, it should back sync ExecutionPayloadEnvelopes from gloas_start_slot. Otherwise, it skips the whole batch potentially not back syncing payload envelopes from some of the first slots in Gloas.
Similar start_slot adjustment is performed in lines 381–387 for blobs.
| // Request execution payload envelopes for Gloas-activated slots | ||
| // Note: Similar to blocks, envelopes are needed for all Gloas slots (not just serve range) | ||
| // This must be checked before serve range checks to ensure envelopes are always requested | ||
| if config.phase_at_slot::<P>(start_slot) >= Phase::Gloas { |
There was a problem hiding this comment.
similar issue here: batch should not be skipped if start_slot < Phase::Gloas, it should only be skipped if start_slot + count < Phase::Gloas, otherwise start_slot and count should be adjusted
- Locally build payload envelope by proposer - Request `engine_getBlobsV2` once envelope receive if data is not available - Reconstruct data column sidecars with payload envelope - Request payload envelopes from peers while syncing
hangleang
force-pushed
the
feature/payload-envelope
branch
from
1e6ec6e to
438e9b6
Compare
2 participants
This PR include changes as follows:
engine_getBlobsV2once envelope receive if data is notavailable
Require the following fixes before ready for review: