Refactor validate_data_column_sidecar_with_state function#657
Open
hangleang wants to merge 1 commit intograndinetech:developfrom
Open
Refactor validate_data_column_sidecar_with_state function#657hangleang wants to merge 1 commit intograndinetech:developfrom
validate_data_column_sidecar_with_state function#657hangleang wants to merge 1 commit intograndinetech:developfrom
Conversation
povi
reviewed
Apr 7, 2026
| block_root, | ||
| )); | ||
| }; | ||
| if !origin.is_from_back_sync() { |
Collaborator
There was a problem hiding this comment.
Duplicate check !origin.is_from_back_sync(). There is a code block with an identical check just above this.
merge check block
hangleang
force-pushed
the
refactor/validate_data_column_sidecar
branch
from
ec794de to
9fc14ae
Compare
povi
reviewed
Apr 17, 2026
| }, | ||
| ); | ||
|
|
||
| // [REJECT] The sidecar is for the correct subnet -- i.e. compute_subnet_for_data_column_sidecar(sidecar.index) == subnet_id. |
Collaborator
There was a problem hiding this comment.
Is this validation is not needed anymore?
Collaborator
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR merge Fulu and Gloas data column sidecar validation into a single unified method to avoid converting between
Arc<DataColumnSidecar>and its underlying type