Skip to content

Fix: Irrelevant 'beside' warning for bar plot without groups#371

Closed
zeileis wants to merge 1 commit intomainfrom
barplot-beside-bug
Closed

Fix: Irrelevant 'beside' warning for bar plot without groups#371
zeileis wants to merge 1 commit intomainfrom
barplot-beside-bug

Conversation

@zeileis
Copy link
Copy Markdown
Collaborator

@zeileis zeileis commented Apr 10, 2025

Fixes #370

Only throw the warning regarding beside=FALSE (rather than TRUE) in the presence of negative y values if there are by groups without facet_by being enabled.

@grantmcdermott
Copy link
Copy Markdown
Owner

Thanks @zeileis. If you don't mind, I'm going to close in favour of #372 (which I had started on my local computer before seeing your PR), since it simplifies the codebase in a few other places too. The specific solution for the beside case is the exact same, though.

@zeileis zeileis deleted the barplot-beside-bug branch April 11, 2025 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Irrelevant 'beside' warning for bar plot without groups

2 participants