chore: remove misleading "v2" from DIPs migration and docs#965
Merged
MoonBoi9001 merged 1 commit intorefactor/billion-entities-pricingfrom Mar 3, 2026
Merged
Conversation
There is no DIPs v1 -- the off-chain voucher system was abandoned before deployment. DIPs refers exclusively to the on-chain RCA system. Rename the migration from dips_v2 to dips_pending_proposals and clean up doc comments that referenced "V2". Also clarifies the migration ownership comment in service.rs: the indexer-service does not run migrations by convention, the agent owns DDL, and the SQL files here are for local dev and tests only. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
MoonBoi9001
merged commit b695ad8
into
refactor/billion-entities-pricing
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The codebase has references to "DIPs v2" implying there was a v1 that preceded it. There wasn't -- the off-chain voucher-based system was abandoned before deployment. DIPs is the on-chain RecurringCollectionAgreement system, full stop. The "v2" label is confusing and should be removed.
Summary
20260209000000_dips_v2to20260302000000_dips_pending_proposals-- describes what the migration does rather than implying a version lineage that doesn't existDipsConfigdoc comment from "DIPS V2 configuration" to "DIPs configuration"service.rs: the indexer-service does not run migrations by convention, the agent owns DDL, and the SQL files here are for local dev and tests only