Conversation
Summary of ChangesHello @adambenhassen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the Model Context Protocol (MCP) integration into the GraphQL Hive Gateway. It enables the gateway to expose its underlying GraphQL operations as discoverable and executable "tools" for AI agents or other MCP-compatible clients. This is achieved through a new Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-hive/gateway |
2.5.10-alpha-fe6fd314380b611e2f6571d873a9595463235dc8 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/nestjs |
2.0.51-alpha-fe6fd314380b611e2f6571d873a9595463235dc8 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/plugin-mcp |
0.1.0-alpha-fe6fd314380b611e2f6571d873a9595463235dc8 |
npm ↗︎ unpkg ↗︎ |
There was a problem hiding this comment.
Code Review
This pull request introduces a prototype implementation of the Model Context Protocol (MCP) as a gateway plugin. The changes are extensive, adding the useMCP plugin, supporting logic for protocol handling, schema conversion to JSON Schema, and an example implementation. The overall structure is sound, but there are a few critical issues related to handling asynchronous operations and validating inputs that could lead to runtime errors and unreliable behavior. I've provided specific comments and suggestions to improve the robustness and correctness of the implementation.
0490f31 to
eb04752
Compare
e100f5e to
eea72b4
Compare
b340151 to
5be6c22
Compare
🚀 Snapshot Release (Bun Docker Image)The latest changes of this PR are available as image on GitHub Container Registry (based on the declared |
🚀 Snapshot Release (Node Docker Image)The latest changes of this PR are available as image on GitHub Container Registry (based on the declared |
8a3375e to
eb0fa1f
Compare
…rop content fallback
…ernal header for MCP tools
04a4e99 to
fe6fd31
Compare
No description provided.