Skip to content

Conversation

@codingllama codingllama added the no-changelog Indicates that a PR does not require a changelog entry label Dec 8, 2025
@codingllama
Copy link
Contributor Author

It was still running locally when I opened, but this will need code fixes. I'll move to draft in the meantime.

@codingllama codingllama marked this pull request as draft December 8, 2025 17:22
@codingllama
Copy link
Contributor Author

codingllama commented Dec 8, 2025

I'm having a hard time with ./integration/appaccess tests locally, but nevertheless I think it should all be good now.

@codingllama codingllama marked this pull request as ready for review December 8, 2025 18:16
@github-actions github-actions bot added audit-log Issues related to Teleports Audit Log database-access Database access related issues and PRs tctl tctl - Teleport admin tool labels Dec 8, 2025
input string
expected types.License
err error
err any
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an error to call errors.As with an error type. The linter shouts (and it's wrong).

@codingllama
Copy link
Contributor Author

PTAL.

@codingllama codingllama added this pull request to the merge queue Dec 9, 2025
Merged via the queue into master with commit 2740ad6 Dec 9, 2025
44 checks passed
@codingllama codingllama deleted the codingllama/bump-golangcilint branch December 9, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

audit-log Issues related to Teleports Audit Log database-access Database access related issues and PRs no-changelog Indicates that a PR does not require a changelog entry size/sm tctl tctl - Teleport admin tool

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants