test(TableColumnSetup): add visual tests#2492
Open
tungulin wants to merge 5 commits intogravity-ui:mainfrom
Open
test(TableColumnSetup): add visual tests#2492tungulin wants to merge 5 commits intogravity-ui:mainfrom
tungulin wants to merge 5 commits intogravity-ui:mainfrom
Conversation
Contributor
|
Preview is ready. |
amje
requested changes
Nov 11, 2025
Contributor
There was a problem hiding this comment.
Seems like "lock" item has different offset. Let's fix it in this PR so screenshot would be correct.
Contributor
Author
There was a problem hiding this comment.
Added tests for different variants popupPlacement
| items: [ | ||
| {id: 'name', title: 'Имя', selected: true, required: true}, | ||
| {id: 'email', title: 'Email', selected: true}, | ||
| {id: 'phone', title: 'Телефон', selected: false}, |
Contributor
There was a problem hiding this comment.
By default we use english texts in demos and examples
Contributor
|
Visual Tests Report is ready. |
Contributor
|
@tungulin You should update screenshots in docker environment only |
Contributor
Author
|
@amje hey! Can you check my MR? plz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2436