Enable deep customization via a new render function prop (DRAFT)#2576
Open
ukqfhf wants to merge 2 commits intogravity-ui:mainfrom
Open
Enable deep customization via a new render function prop (DRAFT)#2576ukqfhf wants to merge 2 commits intogravity-ui:mainfrom
ukqfhf wants to merge 2 commits intogravity-ui:mainfrom
Conversation
ukqfhf
requested review from
NikitaCG,
ValeraS,
amje and
korvin89
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a new render function prop for MenuItem to enable deep customization while still providing access to internal props via arguments.
Why
The current UI kit is highly opinionated. While this ensures consistency, it limits flexibility. Adding a way to bypass the default rendering—while preserving access to styling and core functionality—improves extensibility.
Modern UI kits (e.g., Base UI) include such render function patterns out of the box, allowing users to fully customize component output without losing built‑in behaviors. See: Base UI Handbook – Composition.
Limitations
Currently, there is no universal renderElement or similar utility. As a result, manually inserting render conditions could increase the risk of errors and reduce maintainability.