Skip to content

fix: display Codex free quota as 30-day window#149

Merged
graykode merged 1 commit into
graykode:mainfrom
oliver-ForkHub:fix/codex
Jul 5, 2026
Merged

fix: display Codex free quota as 30-day window#149
graykode merged 1 commit into
graykode:mainfrom
oliver-ForkHub:fix/codex

Conversation

@Iamliuxiaozhen

Copy link
Copy Markdown
Contributor

fix: #141
Related PR:
#142

@graykode

graykode commented Jul 5, 2026

Copy link
Copy Markdown
Owner

Security review:

No blocking security findings from this patch. The change only propagates window_minutes as numeric local rate-limit metadata through the existing model/cache/UI path. I did not see any new command execution, path handling, network access, secret exposure, or terminal-control/string injection risk.

Checked:

  • Codex JSONL parser and account-level rate-limit filtering
  • Codex cache writer/reader
  • quota label rendering
  • RateLimitInfo construction and serialization call sites

Validation:

  • git diff --check origin/main FETCH_HEAD passed
  • GitHub check is passing
  • Local cargo test was not run because this environment does not have cargo/rustc installed.

@graykode graykode left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from a security-review standpoint. I did not find new command execution, path handling, network access, secret exposure, or terminal-control/string injection risk in this patch.

Scope note: local cargo test was not run in my environment because cargo/rustc are unavailable, but the GitHub check job is passing.

@graykode

graykode commented Jul 5, 2026

Copy link
Copy Markdown
Owner

Follow-up validation after local Rust toolchain became available:

  • cargo test passed on PR head 3582207
  • cargo clippy -- -D warnings passed on PR head 3582207

This supersedes my earlier local-test caveat. My security-review approval still stands.

@graykode graykode merged commit f4ddfb4 into graykode:main Jul 5, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The remaining credit limit displayed by Codex under the Chatgpt Free account is incorrect.

2 participants