Adding Rule to remove useless ToString call#122
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a new Roslyn analyzer rule (GCI2508) and code fix intended to remove redundant ToString() calls on string, along with unit tests and rule ID registration in the core rule catalog.
Changes:
- Added GCI2508 analyzer to detect parameterless
string.ToString()calls in selected contexts. - Added a corresponding code fix provider to remove/replace the redundant invocation.
- Added MSTest-based unit tests and registered the new rule ID in
Rule.Ids.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Creedengo.Tests/Tests/GCI2508.RemoveUselessToStringCall.Tests.cs | Adds test coverage for the new analyzer and code fix behavior. |
| src/Creedengo.Core/Models/Rule.cs | Registers the new diagnostic ID constant GCI2508. |
| src/Creedengo.Core/Analyzers/GCI2508.RemoveUselessToStringCall.Fixer.cs | Introduces the code fix that removes/replaces redundant ToString() invocations. |
| src/Creedengo.Core/Analyzers/GCI2508.RemoveUselessToStringCall.cs | Introduces the analyzer that reports redundant string.ToString() invocations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vdebellabre
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.