Add S6605 - Use Exists Instead of Any#123
Merged
vdebellabre merged 2 commits intoMay 20, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a new Roslyn analyzer/code fix rule (GCI6605) that recommends using List<T>.Exists(predicate) instead of LINQ Enumerable.Any(predicate) when the receiver is a List<T> (or derived), with accompanying unit tests and a sandbox example.
Changes:
- Added GCI6605 analyzer to detect
list.Any(predicate)calls onList<T>/derived types (excluding expression-tree contexts). - Added a code fix to replace
AnywithExists. - Added unit tests for positive/negative scenarios and a sandbox file demonstrating the rule.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Creedengo.Core/Analyzers/GCI6605.UseExistsInsteadOfAny.cs | Adds analyzer logic and diagnostic metadata for GCI6605. |
| src/Creedengo.Core/Analyzers/GCI6605.UseExistsInsteadOfAny.Fixer.cs | Adds code fix provider to rewrite Any to Exists. |
| src/Creedengo.Core/Models/Rule.cs | Registers the new rule ID constant. |
| src/Creedengo.Tests/Tests/GCI6605.UseExistsInsteadOfAny.Tests.cs | Adds test coverage for the new analyzer + fixer. |
| src/Creedengo.Sandbox/S6605Sandbox.cs | Adds a sandbox snippet showcasing before/after usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Fixer: use SimpleNameSyntax instead of IdentifierNameSyntax to handle both Any and Any<T> (GenericNameSyntax) cases - Description: fix wording to mention enumerator allocation and interface dispatch instead of incorrect delegate allocation claim - Tests: add AnyWithExplicitTypeArgumentAsync for GenericNameSyntax coverage
vdebellabre
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.