Conversation
Corrected a typo in the comment regarding codecs.open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
open_utf8() used io.open(path, mode, encoding="utf-8"). On the IronPython 2.7 runtime CODESYS's ScriptEngine uses, encoding resolution for io.open is unreliable and can silently fall back to the OS ANSI code page instead of true UTF-8. This corrupts any non-ASCII character (umlauts, accented letters, smart punctuation, Cyrillic) on export, and the next Import From Files then fails with UnicodeDecodeError: 'unknown' codec can't decode byte ....
Switching to codecs.open(path, mode, encoding="utf-8"), the long-standing, well-supported way to do UTF-8 text I/O on Python 2 / IronPython, fixes a full export → import round-trip that previously failed as soon as the project contained non-ASCII text (e.g. German comments with umlauts).
Tested locally: export → import round-trip now succeeds on a project with German-language comments (previously failed with the UnicodeDecodeError above).
