Fix ratings view mode and card display prefs not persisting#22
Merged
Conversation
ratings_view_mode and 8 show_* card display toggles were tracked in the frontend sf object but absent from EXPOSED_KEYS and UpdateSettingsRequest, so the server silently dropped them on PATCH and never returned them on GET. Preferences appeared to save but reset on every page reload. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ratings_view_modeand 8show_*card display toggles were stored in the frontendsfobject but absent fromEXPOSED_KEYSandUpdateSettingsRequestin the settings routerPATCH /api/settingscall and never returned them onGET, so they reset to defaults on every page reloadEXPOSED_KEYSandUpdateSettingsRequestAffected settings that now persist:
Test plan
🤖 Generated with Claude Code