This repository was archived by the owner on Jan 20, 2019. It is now read-only.
Change of top-level namespace to fix conflict with official Amazon aws-sdk#64
Open
itrigga wants to merge 4 commits intogrempe:masterfrom
Open
Change of top-level namespace to fix conflict with official Amazon aws-sdk#64itrigga wants to merge 4 commits intogrempe:masterfrom
itrigga wants to merge 4 commits intogrempe:masterfrom
Conversation
added 4 commits
January 26, 2012 11:03
…cial Amazon AWS SDK gem, which also defines AWS::EC2 but as a class not a module
…cial Amazon AWS SDK gem, which also defines AWS::EC2 but as a class not a module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for the gem, we use it every day at iTrigga. However, since amazon released their official Ruby aws-sdk , we've found that we can't use that and this together.
The aws-sdk gem also defines the AWS::EC2 namespace, however in their case it's a class, not a module - so we can't just require both and get the methods mixed-in. So I took the simplest possible approach to fixing the problem by renaming the top-level namespace in your gem to AWSAPI. I figured if we have this problem, then others probably have too, so here's the pull request. All tests pass.
Thanks again!
Al