Expose packager and transporter structs for use with NewClient2#59
Closed
andig wants to merge 2 commits intogrid-x:masterfrom
Closed
Expose packager and transporter structs for use with NewClient2#59andig wants to merge 2 commits intogrid-x:masterfrom
andig wants to merge 2 commits intogrid-x:masterfrom
Conversation
477bca7 to
4691150
Compare
4691150 to
2ed010f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #56
This PR exposes packers and transporters. It does not modify existing api:
New*TransportermethodsNotes on implementation:
New*Transportermethods would be "annoying" for the linter.TCPTransporter(which is an implementation detail) as part of theASCII/RTUOverTCPtransporters is unfortunate but required to keep the public fields visible.Printf()method was removed- it seems unused (will split into separete PR)TODO
Printf()public api. With makingserialTransportpublic, the transport's logger should be used instead. Proposal: removePrintf()(potential though minor BC break).Alternatives:
Add a
Clone()method that clones the entire client handler, sharing the underlying transport #70.Maybe think about something like: