Return to minimal logger interface#88
Conversation
dammarco
left a comment
There was a problem hiding this comment.
We (@hsteidl ) looked into it and it looks good to us.
As we are referencing to a specific commit of this repo, we didn't experience any breaking changes.
But if you require this interface and the library anyway only sends debug log messages, then we are fine with doing this ;)
@tretmar didn't work. Makes for ugly commit history and potentially harder to merge in forks. |
|
@andig Just to understand you here... you want to have 1 commit per merged PR in the end? |
|
I think that would be great. At least when the PR does not contain an intentional logical breakdown of the changes. |
|
Okay, we're working internally with a different approach - so that's why we don't squash before merging... simply because we are used to a different approach ;) We follow the approach that the authors of PRs are responsible to have a clean commit structure, including squashing. Still, in a public repository like this here, it might not be the best approach as we can't force everyone to follow this clean commit approach 🤔 |
|
@tretmar well you can force people, but why if you can just squash the commits automatically? :-) We are doing this in Telegraf and you can configure Github to do so. The big advantage of squashing IMO is that you do have a cleaner commit history keeping things together, but that's a matter of taste of course... |
Fix #87. Replaces #86. Refs #80 (comment).
Re-exposes
as minimal logger interface, this time as public type.
Please squash before committing.
/cc @tretmar @srebhan