Typescript Capstone Challenge#26
Open
wasyted wants to merge 1 commit intogridu:masterfrom
Open
Conversation
TypeScript Essentials Capstone Challenge Code sample consist of implementation of Observer, Observable and usage of this classes (handling requests). The assignment implies the coverage of the types of the entire code not only Observable & Observer but also request, users objects and observer handlers. Acceptance criteria The code sample should be fully covered with types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR completes the TypeScript Essentials Capstone Challenge by refactoring the existing JavaScript implementation of the Observer and Observable design pattern into fully-typed TypeScript.
Changes Implemented
Generic Observer & Observable Classes:
Strict Type and Interface Definitions:
Enums: Introduced HTTPMethod and HTTPStatus enums to replace raw string and magic numbers.
Interfaces: Added IAppRequest and ISubscription interfaces to define the shape of request objects and subscription contracts.
Type Aliases: Created the User and Handlers types to model the application's data and define the structure for observer handlers (next, error, complete).
Typed Mocks and Functions:
The userMock and requestsMock arrays are now strictly typed against the User and IAppRequest definitions. userMock is also marked as Readonly to enforce immutability.
All handler functions (handleRequest, handleError) and variables (requests$, subscription) have been assigned explicit types.
Acceptance Criteria Checklist